vercel/release

Can't release if there's only 1 commit since last tag

Open

#93 opened on Jun 30, 2017

View on GitHub
 (3 comments) (2 reactions) (0 assignees)JavaScript (145 forks)batch import
bughelp wanted

Repository metrics

Stars
 (3,534 stars)
PR merge metrics
 (No merged PRs in 30d)

Description

I end up with the error Error! No changes happened since the last release. if I have only 1 commit since the last tag.

Seems like the following code might be the issue https://github.com/zeit/release/blob/master/lib/commits.js#L22

  if (commit.hash === release.hash) {
    return
  }

Contributor guide

Research direction
The issue is in lib/commits.js at line 22 where the code returns early if the commit hash matches the release hash. This causes a failure when there is only one commit since the last tag. To fix, the logic should be adjusted to handle the single commit case, possibly by not returning or by checking the number of commits. There are no linked PRs, so the solution is open for implementation. The maintainer has not commented on the issue, so the scope is defined by the reported bug.
Tech stack
javascriptnodejs
Domain
toolingrelease
Issue type
Bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
Under 1 hour
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
Node.jsbasic git knowledge
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
85