vercel/hyper

Prompt before closing the app when a process is running

Open

#684 opened on Sep 2, 2016

View on GitHub
 (20 comments) (10 reactions) (0 assignees)TypeScript (3,558 forks)batch import
good first issuehelp wanted🛠 Type: Feature Request

Repository metrics

Stars
 (44,582 stars)
PR merge metrics
 (No merged PRs in 30d)

Description

Related to #623. Would it be possible to have a prompt before quitting the app when a process is running? It could help to prevent quitting the app with an ongoing process that we won't be able to kill without manually killing the PID.

Contributor guide

Research direction
Investigate how Hyper detects running processes (likely via xterm addon attach or process tracking) and add a confirmation dialog before quitting the app using Electron's dialog module.
Tech stack
typescript
Domain
desktopfrontendbackend
Issue type
Feature
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
GitElectronNode.js
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
60