vectordotdev/vector

metrics: rename memory enrichment table counters to end with _total

Open

#25,455 opened on May 18, 2026

View on GitHub
 (5 comments) (0 reactions) (0 assignees)Rust (2,126 forks)batch import
domain: enrichment_tablesdomain: metricsgood first issuesource: internal_metrics

Repository metrics

Stars
 (21,837 stars)
PR merge metrics
 (Avg merge 5d 12h) (85 merged PRs in 30d)

Description

Summary

Three counter metrics in the memory enrichment table are missing the _total suffix, violating the instrumentation spec.

From docs/specs/instrumentation.md: "Counters MUST end with total"

Metrics to rename

Current name Correct name
memory_enrichment_table_failed_insertions memory_enrichment_table_failed_insertions_total
memory_enrichment_table_failed_reads memory_enrichment_table_failed_reads_total
memory_enrichment_table_ttl_expirations memory_enrichment_table_ttl_expirations_total

These are defined in lib/vector-common/src/internal_event/metric_name.rs as CounterName variants. Their descriptions already say "The total number of..." confirming the intent was to follow the _total convention.

Notes

These are breaking changes for anyone scraping these metrics directly. The old names should be kept as deprecated aliases or the rename should be accompanied by a changelog entry.

Contributor guide

Research direction
Find the CounterName enum in lib/vector common/src/internal event/metric name.rs, rename the three variants to end with total, and ensure the old names are kept as deprecated aliases according to the instrumentation spec.
Tech stack
rust
Domain
backend
Issue type
Bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
Git
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
75