vectordotdev/vector

prometheus_scrape source should have request headers configurable

Open

#19,656 opened on Jan 18, 2024

View on GitHub
 (5 comments) (2 reactions) (0 assignees)Rust (2,126 forks)batch import
good first issuesource: prometheus_scrapetype: feature

Repository metrics

Stars
 (21,837 stars)
PR merge metrics
 (Avg merge 5d 12h) (85 merged PRs in 30d)

Description

A note for the community

  • Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request
  • If you are interested in working on this issue or have submitted a pull request, please leave a comment

Use Cases

For example, Hashicorp Vault requires Accept: prometheus/telemetry or Accept: application/openmetrics-text] headers to be present in request to return metrics in Prometheus format.

https://developer.hashicorp.com/vault/docs/configuration/telemetry#prometheus

Attempted Solutions

No response

Proposal

prometheus_scrape source should have request headers configurable, as http_client already do.

References

No response

Version

0.35.0

Contributor guide

Research direction
Look at the existing prometheus scrape source implementation (likely in `src/sources/prometheus/scrape.rs`). Examine how http client already supports configurable headers (e.g., in `src/sinks/http.rs` or `src/http.rs`). Propose adding a similar `headers` configuration field to the prometheus scrape source and integrate it into the HTTP requests made by that source. Check the configuration schema and ensure the fields are properly validated.
Tech stack
rust
Domain
backenddata
Issue type
Feature
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
Half day
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Fresh
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
Rust programmingVector's source configurationHTTP protocol basics
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
65