validatorjs/validator.js

Feature Request: Currency: Option to Require Thousands Separator

Open

#912 opened on Oct 15, 2018

View on GitHubContributor guide
 (7 comments) (0 reactions) (0 assignees)JavaScript (2,489 forks)batch import
good first issuehelp neededpr-raised🙋‍♂️feature-request

Repository metrics

Stars
 (23,739 stars)
PR merge metrics
 (Avg merge 10h 14m) (2 merged PRs in 30d)

Description

We're using this to help validate data that includes currency. We want to make sure that a comma separator is always present.

Contributor guide

Research direction
Examine the isCurrency function in the source code. Understand how options like symbol, require symbol, and locale work. Add a new option e.g., require thousands separator. Modify the regex to enforce the separator. Write tests to validate the behavior.
Tech stack
javascript
Domain
backend
Issue type
Feature
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
JavaScript
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
75