unslothai/unsloth

NEFTune - check if it functions correctly - `neftune_post_forward_hook` removed from trl

Closed

#1,078 opened on Sep 30, 2024

View on GitHubContributor guide
 (13 comments) (0 reactions) (0 assignees)Python (5,658 forks)batch import
good first issue

Repository metrics

Stars
 (64,271 stars)
PR merge metrics
 (Avg merge 3d 15h) (525 merged PRs in 30d)

Description

Hi unsloth,

FYI, neftune_post_forward_hook has been removed from trl in https://github.com/huggingface/trl/pull/1841

cc @lewtun @kashif

Contributor guide

Research direction
Investigate the trl pull request #1841 that removed `neftune post forward hook`. Check unsloth's codebase for usage of this hook, particularly in files related to NEFTune. Determine if unsloth's NEFTune functionality is broken or needs adaptation. Look at comments in the issue for additional context from maintainers like @lewtun and @kashif. Suggest a fix if unsloth's implementation relies on the removed hook, such as using an alternative approach or updating to match trl's new design.
Tech stack
pythonpytorch
Domain
machine learning
Issue type
Bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
Half day
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Mostly clear
Prerequisites
basic understanding of NEFTunefamiliarity with trl library
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
50