unoplatform/uno

[Skia] Shapes arrange appear to be broken in certain cases

Closed

#18,265 opened on Sep 21, 2024

View on GitHubContributor guide
 (5 comments) (0 reactions) (0 assignees)C# (837 forks)batch import
area/skia ✏️difficulty/tbdgood first issuekind/buglow-hanging-🍒project/layout 🧱project/shapes-brushes 🔶

Repository metrics

Stars
 (9,789 stars)
PR merge metrics
 (Avg merge 14d 8h) (130 merged PRs in 30d)

Description

Current behavior

Using Basic_Shapes sample, there is at least one broken scenario using Ellipse, UniformToFill, FixedWidthLarge.

Here is WinUI vs Skia comparison:

image

Somehow, vertical alignment isn't taking effect?

Simple repro:

<Grid Width="150" Height="150" BorderBrush="Green" BorderThickness="1">
<Ellipse Width="300" Stretch="UniformToFill" HorizontalAlignment="Left" VerticalAlignment="Bottom" Fill="Red" />
</Grid>

Expected behavior

No response

How to reproduce it (as minimally and precisely as possible)

No response

Workaround

No response

Works on UWP/WinUI

None

Environment

No response

NuGet package version(s)

No response

Affected platforms

No response

IDE

No response

IDE version

No response

Relevant plugins

No response

Anything else we need to know?

No response

Contributor guide

Research direction
Investigate the SkiaSharp rendering code path for shapes, particularly the Ellipse shape with Stretch.UniformToFill and VerticalAlignment. Look for relevant layout/arrange logic in the Uno.UI.Skia package. Review the issue comments for any debugging hints or suggested fixes.
Tech stack
csharp
Domain
frontend
Issue type
Bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
Half day
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
Familiarity with XAML layoutBasic understanding of SkiaSharp
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
60