ungoogled-software/ungoogled-chromium

utils/downloads.py should check HTTP response before renaming

Open

#1,805 opened on Jan 20, 2022

View on GitHubContributor guide
 (0 comments) (1 reaction) (0 assignees)Python (771 forks)batch import
enhancementhelp wanted

Repository metrics

Stars
 (18,674 stars)
PR merge metrics
 (PR metrics pending)

Description

utils/downloads.py should check HTTP response and rename downloaded files only if HTTP 200 OK response received. https://github.com/Eloston/ungoogled-chromium/blob/93cf016effb260428578c765e53b33020bc170d6/utils/downloads.py#L222-L235

Contributor guide

Research direction
Check the HTTP response from requests.get() and only rename if status code is 200. Modify lines 222-235 of utils/downloads.py to add a condition.
Tech stack
python
Domain
backend
Issue type
Bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
Under 1 hour
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Fresh
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
GitPython
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
85