uclasoles/UCLA-SOLES-website

Look into why react-router Route doesn't want to take components in

Open

#27 opened on Jul 24, 2019

View on GitHubContributor guide
 (0 comments) (0 reactions) (0 assignees)JavaScript (1 fork)auto 404
cleanupgood first issueimpact-low

Repository metrics

Stars
 (3 stars)
PR merge metrics
 (PR metrics pending)

Description

For some reason you need to declare components in react-router Route component like this: <Route exact path={ROUTES.SIGN_UP} render={(props) => <SignUp {...props} />} /> instead of like this:

In order to not get red warnings on Mozilla FireFox.

Contributor guide

Research direction
Investigate why using the 'component' prop in react router Route causes warnings in Firefox while 'render' prop works. Check react router documentation and known issues.
Tech stack
javascriptreact
Domain
frontend
Issue type
Bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
1
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
Under 1 hour
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Fresh
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
Reactreact router
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
80