turicas/rows

Optimize if output format is SQLite

Open

#217 opened on Feb 20, 2017

View on GitHubContributor guide
 (0 comments) (0 reactions) (0 assignees)Python (136 forks)github user discovery
clienhancementhelp wanted

Repository metrics

Stars
 (886 stars)
PR merge metrics
 (No merged PRs in 30d)

Description

If we run the following command:

rows query 'SELECT * FROM table1 WHERE field1="value1"' filename.sqlite --output=out.sqlite

the CLI will:

  • Connect to a SQLite database named filename.sqlite since there's only one source and it's format is SQLite
  • Import the SQLite result into a rows.Table running the query
  • Export the result rows.Table into a new SQLite database named out.sqlite

We can optimize this use case replacing the steps with the following:

  • Connect to a SQLite database named filename.sqlite since there's only one source and its format is SQLite
  • Attach the output database with SQLite's ATTACH SQL command
  • Change the query to have INSERT INTO (to add result to the new database)
  • Run the query

More details on ATTACH in StackOverflow this thread.

Contributor guide

Research direction
Investigate using SQLite ATTACH DATABASE to avoid exporting and re importing the table; modify the query to use INSERT INTO with the attached database.
Tech stack
python
Domain
backend
Issue type
Performance
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
PythonSQLSQLite
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
60