turicas/rows

[XLS, XLSX] Use another sheet name if already exists

Open

#185 opened on Aug 15, 2016

View on GitHubContributor guide
 (2 comments) (0 reactions) (0 assignees)Python (136 forks)github user discovery
bughelp wantedplugin

Repository metrics

Stars
 (886 stars)
PR merge metrics
 (No merged PRs in 30d)

Description

rows will try to export sheets with name "Sheet1" but it's going to overwrite if the sheet already exists (in fact, opening the file in wb mode will overwrite it anyway).

Tasks:

  • Create a test for this scenario and fix it (could be based on plugin SQLite's table name test, which already has this feature);
  • Check if the problem of opening the file as wb occurs in other plugins also and create new issues if needed.

Contributor guide

Research direction
Create a test that writes multiple sheets with the same name, then modify the XLS/XLSX plugin to generate an alternate sheet name (e.g., 'Sheet1 1') if the name already exists. Use the plugin SQLite's approach as a reference.
Tech stack
python
Domain
backenddata
Issue type
Bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
Half day
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
GitPython
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
65