trycua/cua

Variable shadowing in computer class breaks shared directories.

Open

#124 opened on Apr 23, 2025

View on GitHub
 (3 comments) (0 reactions) (0 assignees)HTML (1,051 forks)batch import
good first issue

Repository metrics

Stars
 (16,722 stars)
PR merge metrics
 (Avg merge 1d) (166 merged PRs in 30d)

Description

This section in the Computer.__init__ method:

 if shared_directories:
    for path in shared_directories:
        abs_path = os.path.abspath(os.path.expanduser(path))  # type: ignore[attr-defined]
        if not os.path.exists(abs_path):  # type: ignore[attr-defined]
            raise ValueError(f"Shared directory does not exist: {path}")
        self.shared_paths.append(abs_path)

fails with:

abs_path = os.path.abspath(os.path.expanduser(path))  # type: ignore[attr-defined]
               ^^^^^^^
AttributeError: 'str' object has no attribute 'path'

because the module name is being shadowed by the init variable os, which is a string (macos, linux).

Please fix.

Contributor guide

Research direction
The bug is in the `Computer. init ` method where the variable `os` shadows the `os` module. The fix is to rename the variable `os` to something like `os name` to avoid shadowing. The specific code is in the file containing the `Computer` class (likely `computer.py` or similar). After renaming, ensure the `os.path` and `os.path.exists` calls work correctly.
Tech stack
python
Domain
backend
Issue type
Bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
1
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
Under 1 hour
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Fresh
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
basic Pythonunderstanding of variable shadowing
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
90