trunk-rs/trunk

Support custom build command / other wasm targets

Open

#830 opened on Jul 25, 2024

View on GitHubContributor guide
 (3 comments) (0 reactions) (0 assignees)Rust (315 forks)auto 404
enhancementhelp wanted

Repository metrics

Stars
 (4,347 stars)
PR merge metrics
 (PR metrics pending)

Description

Problem

Trunk is currently hard coded to build for wasm32-unknown-unknown, making it hard to work with other wasm targets (wasm64, wasi targets)

Solution

A simple way to unblock other wasm targets is to provide an option to disable the default wasm32 build. I think a default_build = true entry in Trunk.toml would suffice. If the option is explicitly set to false, we just don't add the default wasm32 build here https://github.com/trunk-rs/trunk/blob/d61478448bd093449708b63dcb3e7baf286a191c/src/pipelines/html.rs#L150

See this discussion for more context.

If this is the right approach I can work on a PR.

Contributor guide

Research direction
Look at the Trunk.toml configuration file and the src/pipelines/html.rs file around line 150 to understand where the default wasm32 build is added. Consider adding a default build option in Trunk.toml and conditionally skipping the default build when set to false.
Tech stack
rust
Domain
toolingbuild system
Issue type
Feature
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
Under 1 hour
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
Rust
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
85