trixi-framework/Trixi.jl

Checklist to update elixirs to use a better default wave speed for Local Lax-Friedrichs

Open

#2,464 opened on Jul 3, 2025

View on GitHub
 (2 comments) (1 reaction) (0 assignees)Julia (153 forks)batch import
good first issuepossible student projecttesting

Repository metrics

Stars
 (686 stars)
PR merge metrics
 (Avg merge 9d 1h) (37 merged PRs in 30d)

Description

The PR https://github.com/trixi-framework/Trixi.jl/pull/2458/files swaps out Trixi.jl's old wave-speed estimate for a better wave-speed estimate. However, because this would break a lot of CI, #2458 retains the old "naive" wave-speed estimate in elixirs.

This issue is intended to track which CI tests are currently being or have been updated.

  • dgmulti_1d
  • dgmulti_2d
  • dgmulti_3d
  • p4est_2d_dgsem
  • p4est_3d_dgsem
  • paper_self_gravitating_gas_dynamics
  • special_elixirs
  • structured_1d_dgsem
  • structured_2d_dgsem
  • structured_3d_dgsem
  • t8code_2d_dgsem
  • t8code_3d_dgsem
  • tree_1d_dgsem
  • tree_2d_dgsem
  • tree_3d_dgsem
  • unstructured_2d_dgsem
  • unstructured_2d_fdsbp
  • miscellaneous items in test (see #2458)

Contributor guide

Research direction
Review PR #2458 to understand the new wave speed estimate and the corresponding changes. Then, for each elixir listed in the checklist, locate the test file and replace the old estimate with the new one. Run the test to ensure it passes. The changes are localized and repetitive.
Tech stack
None
Domain
testing
Issue type
Refactor
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-2 days
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Fresh
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
Familiarity with Trixi.jl test suiteUnderstanding of wave speed estimates
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
70