trinodb/trino

Prefer Guava's Collectors over JDK's

Closed

#6,800 opened on Feb 2, 2021

View on GitHubContributor guide
 (9 comments) (1 reaction) (0 assignees)Java (2,678 forks)batch import
good first issuemaintenance

Repository metrics

Stars
 (9,113 stars)
PR merge metrics
 (Avg merge 5d 9h) (306 merged PRs in 30d)

Description

FYI:

kokosing@m16:~/presto$ git grep 'toImmutableMap(' | wc -l
202
kokosing@m16:~/presto$ git grep 'toMap(' | wc -l
95

Originally posted by @kokosing in https://github.com/trinodb/trino/issues/6761#issuecomment-771581751

Contributor guide

Research direction
Find all usages of JDK's toMap collector and replace each with Guava's toImmutableMap. Ensure the new collector produces an immutable map as expected.
Tech stack
java
Domain
backend
Issue type
Refactor
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
Java
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
70