trinodb/trino

Improve CLI prompt color on dark terminal background

Closed

#6,190 opened on Dec 3, 2020

View on GitHubContributor guide
 (3 comments) (3 reactions) (0 assignees)Java (2,678 forks)batch import
good first issue

Repository metrics

Stars
 (9,113 stars)
PR merge metrics
 (Avg merge 5d 9h) (306 merged PRs in 30d)

Description

For me, on a dark themed terminal, presto prompt is invisible.

Pic: Screenshot 2020-12-03 at 12 36 05

Screenshot 2020-12-03 at 12 36 22

Contributor guide

Research direction
Locate the prompt color configuration in the CLI code (likely in Java) and adjust it to be visible on both light and dark backgrounds by using a more neutral color or adding a theme option.
Tech stack
java
Domain
cli
Issue type
Bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
1
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
Under 1 hour
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
Git
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
80