translate-tools/linguist

Add the popup next to the marked text and not next to the mouse

Open

#376 opened on Jul 3, 2023

View on GitHub
 (3 comments) (0 reactions) (0 assignees)TypeScript (50 forks)auto 404
RFCUIenhancementgood first issuehelp wanted

Repository metrics

Stars
 (1,033 stars)
PR merge metrics
 (PR metrics pending)

Description

First of all, I hope this is not a duplicate, I looked to see if this idea was suggested before and found no result.

When I mark a text to be translated with the popup, the popup is positioned next to the mouse when I release the left click to stop marking text.

Perhaps it is a desired behavior, personally I think it would be better if it were placed next to the text, in the last word that I am going to translate.

Contributor guide

Research direction
Investigate the popup positioning logic in the extension. Currently, it uses mouse event coordinates. Change to use the bounding rect of the selected text (Selection API) and position the popup near the end of the selection.
Tech stack
typescriptjavascript
Domain
frontend
Issue type
Feature
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
1
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
Under 1 hour
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
DOMEvent handling
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
85