trailofbits/graphtage

Expects quoted attributes in HTML unnecessarily, preventing diffing

Open

#25 opened on Aug 31, 2020

View on GitHub
 (1 comment) (0 reactions) (1 assignee)Python (54 forks)auto 404
bugenhancementgood first issue

Repository metrics

Stars
 (2,474 stars)
PR merge metrics
 (PR metrics pending)

Description

When trying to diff an HTML file, Graphtage throws an error when encountering e.g.:

<meta name=foo

because it expects quoted attributes like so:

<meta name="foo"

However, the first variant without quotes is perfectly valid HTML and should not prevent Graphtage from diffing the file.

Contributor guide

Research direction
Examine Graphtage's HTML parsing logic to find where it enforces quoted attributes. Modify the parser to accept unquoted attribute values as valid HTML.
Tech stack
python
Domain
backend
Issue type
Bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
GitPython
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
60