tinacms/tina-starter-grande

Read user preference for dark mode

Open

#6 opened on Nov 5, 2019

View on GitHub
 (0 comments) (0 reactions) (0 assignees)JavaScript (88 forks)auto 404
enhancementgood first issue

Repository metrics

Stars
 (223 stars)
PR merge metrics
 (PR metrics pending)

Description

Right now the theme reads localStorage to see if there's an existing isDarkMode preference, but it doesn't check the user's prefers-color-scheme setting (system setting). This is likely an easy upgrade to the existing logic.

Contributor guide

Research direction
In the existing theme logic that reads localStorage for isDarkMode, also check the window.matchMedia('(prefers color scheme: dark)') media query. Update the initial state accordingly and listen for changes to dynamically update the theme.
Tech stack
javascriptreact
Domain
frontend
Issue type
Feature
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
1
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
Under 1 hour
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Fresh
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
JavaScriptCSS
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
85