terkelg/tiny-glob

Some files are missing when doing glob

Open

#28 opened on Sep 1, 2018

View on GitHub
 (10 comments) (0 reactions) (0 assignees)JavaScript (27 forks)github user discovery
bughelp wanted

Repository metrics

Stars
 (855 stars)
PR merge metrics
 (No merged PRs in 30d)

Description

I have this code:

              const searchPattern = '{post,page}/**/*.{md}'
              glob(searchPattern, {
                cwd: content,
                absolute: true
              })
                .then(files => {
                  console.log(files.length)
                  callback(null, files)
                })
                .catch(err => callback(err))

And I would expect the files for {post,page}/**/*.{md} = {post}/**/*.{md} + {page}/**/*.{md}, but it's not in my case.

I have 2 files for {page}/**/*.{md}, and 53 files for {post}/**/*.{md}, but only 33 for {post,page}/**/*.{md}. Am I doing something wrong here? The searchPattern just works fine under node-glob, fast-glob.

Contributor guide

Research direction
Investigate the brace expansion logic in tiny glob to ensure that patterns like `{post,page}/**/*.{md}` correctly expand and match all files. Compare behavior with node glob and fast glob. Write a test case reproducing the issue.
Tech stack
javascript
Domain
tooling
Issue type
Bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
Half day
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Mostly clear
Prerequisites
Node.jsGlob patterns
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
75