tektoncd/pipeline

Cleanup 馃Ч `pipelinerunresolution_test.go` 馃Ч and move mock data, status mutations and selectors to testing framework.

Open

#8,921 opened on Jul 25, 2025

View on GitHubContributor guide
聽(6 comments)聽(0 reactions)聽(1 assignee)Go聽(1,943 forks)auto 404
area/testinggood first issuehelp wantedkind/cleanup

Repository metrics

Stars
聽(9,013 stars)
PR merge metrics
聽(PR metrics pending)

Description

Summary

Refactor pipelinerunresolution_test.go a bit and move testing helpers to the new testing framework location:

  • Move all mock data creation to pkg/reconciler/testing/factory.go, i.e. var p = ..., var pts = ..., newTaskRun(), ...
    • rename the single letter variables to proper names e.g. p => pipeline, pts = pipelineTasks, ...
  • Move all status transformers to pkg/reconciler/testing/status.go, i.e makeSucceed(), withCanceled()...
  • Move all selectors to pkg/reconciler/testing/selectors.go, i.e. nopGetCustomRun, ...

This is a good first issue.

Related issue #8906.

/help /good-first-issue /kind cleanup

Contributor guide

Research direction
Read the existing test helpers in the test file and move them to the appropriate files in pkg/reconciler/testing/, ensuring imports and references are updated. Check the related issue #8906 for context.
Tech stack
go
Domain
backendtesting
Issue type
Refactor
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
GitGo
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
85