tc39/ecma262

Index conversion in ArrayAccumulation

Open

#1,095 opened on Feb 9, 2018

View on GitHubContributor guide
 (18 comments) (0 reactions) (0 assignees)HTML (1,409 forks)batch import
good first issueneeds consensusneeds test262 testsnormative change

Repository metrics

Stars
 (15,626 stars)
PR merge metrics
 (Avg merge 92d 19h) (17 merged PRs in 30d)

Description

ArrayAccumulation computes the array index via ToString(ToUint32(nextIndex+padding)). This means the index may become 2^32-1. But that's not a valid array index anymore since it is the max value of the length property.

Contributor guide

Research direction
Examine the ArrayAccumulation algorithm in the ECMAScript specification and verify whether `ToString(ToUint32(nextIndex+padding))` can produce an index value of 2^32-1, which is not a valid array index. Propose a fix to ensure the index is within valid range.
Tech stack
javascript
Domain
documentation
Issue type
Bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
None
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
30