swiftlang/swift-package-manager

[SR-10799] SwiftPM should have a --no-network flag that ensures no network calls are made

Open

#4,705 opened on May 30, 2019

View on GitHub
 (5 comments) (0 reactions) (0 assignees)Swift (1,462 forks)batch import
good first issue

Repository metrics

Stars
 (10,145 stars)
PR merge metrics
 (Avg merge 8d 1h) (76 merged PRs in 30d)

Description
Previous ID SR-10799
Radar rdar://problem/43436501
Original Reporter @neonichu
Type Improvement
Votes 0
Component/s Package Manager
Labels Improvement, StarterBug
Assignee None
Priority Medium

md5: 149f4ca03a0e456fe520b79cf5b66d9d

Issue Description:

SwiftPM should have a --no-network flag that ensures no network calls are made.

When SwiftPM would hit a case of needing to use the network, but this flag would be specified, SwiftPM would fail and describe what it needed to do.

This is important for testing scenarios when the package resolution and build are happening separately and in different environments.

Contributor guide

Research direction
Investigate current network call locations in SwiftPM's source code, particularly in the PackageGraph and DependencyResolution phases. Look at how other flags like ` cache path` are implemented to understand the pattern. Then, add a new ` no network` flag to the CLI options struct and check its value before making any network requests. If set, emit a descriptive error message and abort.
Tech stack
swift
Domain
clibuild system
Issue type
Feature
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
Swift basicsSwiftPM project setupCommand line argument parsing
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
75