sveltejs/language-tools

Yarn 2 PnP error - Cannot find type definition file for 'svelte'

Open

#1,018 opened on May 22, 2021

View on GitHubContributor guide
 (0 comments) (4 reactions) (0 assignees)TypeScript (247 forks)auto 404
bughelp wanted

Repository metrics

Stars
 (1,437 stars)
PR merge metrics
 (PR metrics pending)

Description

Describe the bug If .svelte file has no <script></script>, Svelte for VSCode reports Cannot find type definition file for 'svelte' error from js extension - see screenshot for more.

To Reproduce

  1. Clone https://github.com/ochmanski/sveltejs-language-tools-pnp-issue
  2. Go to src/routes/about.svelte to see the issue
  3. Go to src/routes/about-script-workaround.svelte to see how issue disappears when there's a script tag

Expected behaviour There should be no error. Sapper / Svelte compiles fine, run yarn dev to verify that.

Screenshots Issue:

Workaround:

System (please complete the following information):

  • OS: macOS
  • IDE: VSCode
  • Plugin/Package: Svelte for VSCode
  • Yarn version: 2.4.1
  • VSCode version: 1.56.2

Contributor guide

Research direction
Investigate how the Svelte language server resolves type definitions for .svelte files without script tags under Yarn 2 PnP. Check the language server's module resolution algorithm and how PnP's virtual file system affects type lookup. Look for differences in type definition discovery between files with and without script tags.
Tech stack
typescriptsvelte
Domain
frontenddeveloper experience
Issue type
Bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
SvelteYarn 2 PnP
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
45