streamich/memfs

Bug: `git-opfs` demo doesn't work in Safari

Open

#963 opened on Nov 2, 2023

View on GitHubContributor guide
 (2 comments) (1 reaction) (0 assignees)TypeScript (147 forks)github user discovery
help wanted

Repository metrics

Stars
 (2,062 stars)
PR merge metrics
 (Avg merge 4d 8h) (8 merged PRs in 30d)

Description

I tried opening the git-opfs demo in Safari and got a runtime error: DataCloneError: The object can not be cloned.

Image

According to MDN, Safari supports OPFS so I'd expect this example to work.

Note: The demo works as expected in Chrome.

Steps to reproduce

  1. Clone the memfs repository
  2. Install dependencies (yarn)
  3. Run the git-opfs demo (yarn demo:git-opfs)
  4. Open https://localhost:9876 in Safari (I needed to bypass the https security risk warning)

Versions

  • memfs: 4.6.0
  • Safari: Version 17.1 (19616.2.9.11.7)
  • macOS: Sonoma 14.1

Contributor guide

Research direction
Investigate the DataCloneError in Safari when using the origin private file system. Check if the issue is related to the FileSystemFileHandle or FileSystemDirectoryHandle not being clonable in Safari. Reproduce the demo and identify which object fails to clone.
Tech stack
typescriptjavascript
Domain
frontend
Issue type
Bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
Git
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
65