storybookjs/storybook

[Bug]: automigrate fails on EXDEV error

Open

#30,184 opened on Jan 3, 2025

View on GitHub
 (5 comments) (2 reactions) (0 assignees)TypeScript (10,058 forks)batch import
automigrationsbughelp wantedwindows

Repository metrics

Stars
 (89,909 stars)
PR merge metrics
 (Avg merge 9d 3h) (173 merged PRs in 30d)

Description

Describe the bug

Running the command automigrate on windows, it tries to move the logfile from user's temp folder to the current project folder by renaming it. This fails, if temp folder and project folder are on different drives/partitions with the error: Error: EXDEV: cross-device link not permitted, rename 'C:\Users\[USER]\AppData\Local\Temp\435cc8918d4e493a2eb400fc4351782f\migration-storybook.log' -> '.\migration-storybook.log'

Reproduction link

NONE

Reproduction steps

No response

System

Storybook Environment Info:

  System:
    OS: Windows 11 10.0.22631
    CPU: (16) x64 AMD Ryzen 7 PRO 7840U w/ Radeon 780M Graphics
  Binaries:
    Node: 22.12.0 - C:\Program Files\nodejs\node.EXE
    npm: 11.0.0 - ~\AppData\Roaming\npm\npm.CMD <----- active
  Browsers:
    Edge: Chromium (128.0.2739.79)
  npmPackages:
    @storybook/addon-a11y: ^8.4.7 => 8.4.6
    @storybook/addon-coverage: ^1.0.4 => 1.0.4
    @storybook/addon-docs: ^8.4.7 => 8.4.6
    @storybook/addon-essentials: ^8.4.7 => 8.4.6
    @storybook/addon-interactions: ^8.4.7 => 8.4.6
    @storybook/addon-jest: ^8.4.7 => 8.4.6
    @storybook/addon-links: ^8.4.7 => 8.4.6
    @storybook/angular: ^8.4.7 => 8.4.6
    @storybook/core-server: ^8.4.7 => 8.4.6
    @storybook/test-runner: 0.19.0 => 0.19.0
    storybook: ^8.4.7 => 8.2.8
  npmGlobalPackages:
    @storybook/cli: 8.4.7

Additional context

No response

Contributor guide

Research direction
Investigate the automigrate utility in the Storybook core server package. Locate where the log file is being moved using `fs.rename` (likely in `lib/core server/src/utils/automigrate.ts` or similar). Replace `fs.rename` with a cross device safe copy and delete approach (e.g., using `fs.copyFile` and `fs.unlink`). Ensure to handle edge cases where the source and destination are on the same device (the rename can still be used for performance). Check existing tests and consider adding a test for cross device scenarios.
Tech stack
typescriptnodejs
Domain
cli
Issue type
Bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
Under 1 hour
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Fresh
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
Node.js file systemStorybook automigrate
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
70