status-im/status-app

Return `seq[ContactsDetails]` from `getContactsByGroup`

Open

#10,807 opened on May 25, 2023

View on GitHub
 (1 comment) (0 reactions) (0 assignees)QML (96 forks)auto 404
core-teamgood first issuerefactor

Repository metrics

Stars
 (363 stars)
PR merge metrics
 (PR metrics pending)

Description

TLDR: the getContactsByGroup function in src/app_service/service/contacts/service.nim currently returns seq[ContactsDto], but that return value is most of the time used to get ContactsDetails and the original property is already ContactsDetails, so we're doing type transfers uselessly. So change the signature to return seq[ContactsDetails] directly

          Maybe return `seq[ContactsDetails]` from this function?

Originally posted by @igor-sirotin in https://github.com/status-im/status-desktop/pull/10805#discussion_r1205503613

          This function is called with `getContacts` in `initContactRequestsModel`.
          And then for each contact we call `createItemFromPublicKey` which calls `getContactDetails`.

          So we do have `ContactDetails` in the beginning, then switch it to `ContactDto` and eventually back to `ContactDetails`.

Originally posted by @igor-sirotin in https://github.com/status-im/status-desktop/pull/10805#discussion_r1205535598

Contributor guide

Research direction
Modify the return type of getContactsByGroup in src/app service/service/contacts/service.nim from seq[ContactsDto] to seq[ContactsDetails], then update all callers to avoid unnecessary conversions.
Tech stack
None
Domain
desktop
Issue type
Refactor
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
Under 1 hour
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
Nim
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
75