srid/ema

Malformed HTML breaks morphdom (link click fails)

Open

#65 opened on Dec 24, 2021

View on GitHub
 (1 comment) (0 reactions) (0 assignees)Haskell (9 forks)github user discovery
buggood first issuemorphdom

Repository metrics

Stars
 (127 stars)
PR merge metrics
 (No merged PRs in 30d)

Description

If the HTML served is malformed, the dev server's web socket code is unable to switch to the new page on link clicks because morphdom fails to apply the new HTML. The user will see the new URL appear in address bar, but the HTML itself wouldn't change.

Proposal: have Ema display a 'Bad HTML' error message in place.

Here's one malformed HTML:

<meta property="og:title" content="Posts tagged " non-tech" - Maralorns Blog">

Contributor guide

Research direction
Examine the dev server's HTML processing pipeline to identify where malformed HTML causes morphdom to fail; consider adding validation and error display.
Tech stack
haskell
Domain
backend
Issue type
Bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
Git
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
70