square/workflow-kotlin

Make dialogs drive Activity.onUserInteraction

Open

#313 opened on Feb 8, 2021

View on GitHubContributor guide
 (0 comments) (0 reactions) (0 assignees)Kotlin (112 forks)github user discovery
good first issuemodalsui

Repository metrics

Stars
 (1,118 stars)
PR merge metrics
 (Avg merge 55d 8h) (9 merged PRs in 30d)

Description

That method is supposed to report any user interaction in the app, but it ignores Dialog windows. (DialogFragment reportedly has the same problem.) The fix is really simple, see this Stack Overflow comment.

Contributor guide

Research direction
Implement the fix by overriding dispatchKeyEvent or onUserInteraction in Dialogs to call Activity.onUserInteraction. See the Stack Overflow comment referenced in the issue for implementation details.
Tech stack
kotlin
Domain
mobile
Issue type
Bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
1
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
Under 1 hour
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Fresh
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
AndroidKotlinDialogs
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
90