spring-cloud/spring-cloud-netflix

Update Eureka client status URL based on SSL configuration

Open

#1,843 opened on Apr 7, 2017

View on GitHub
 (12 comments) (0 reactions) (0 assignees)Java (2,433 forks)batch import
enhancementhelp wanted

Repository metrics

Stars
 (4,805 stars)
PR merge metrics
 (Avg merge 2d 6h) (5 merged PRs in 30d)

Description

Hi,

If I use secure-port in my configuration and I don't specify the management.port, then spring cloud does not change my eureka statusPageUrl and other url's to https.
The if condition at line number 114 in EurekaClientAutConfiguraiton.java (spring-cloud-netflix-eureka-client: 1.2.6 release) prevents it from changing the scheme and it lets netflix configure the url . In netflix's InstanceInfo.java there is no check for secure port and the protocol is hardcoded to http.

I am not sure where to raise this issue, but since I am using spring-cloud-netflix I am putting this here

Contributor guide

Research direction
Examine the condition at line 114 in EurekaClientAutoConfiguration.java that prevents updating the statusPageUrl scheme to HTTPS when secure port is set but management.port is not specified. Also review InstanceInfo.java from Netflix's Eureka client where the protocol is hardcoded to http. Consider modifying the condition to check for secure port presence, or change the default behavior to respect secure port. Test with secure port configuration and verify that status and health URLs use HTTPS.
Tech stack
java
Domain
backendcloud
Issue type
Bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Mostly clear
Prerequisites
Understanding of Spring Cloud Netflix Eureka client configurationKnowledge of Java and Spring Boot
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
40