spring-cloud/spring-cloud-gateway
View on GitHubIdentical Routes are not considered equal: AsyncPredicate does not override equals()
Open
#3,236 opened on Jan 25, 2024
bughelp wanted
Repository metrics
- Stars
- (4,284 stars)
- PR merge metrics
- (Avg merge 2d 2h) (15 merged PRs in 30d)
Description
Two logically equal Routes are not programmatically equal since Route's equals() compares predicates, and the AsyncPredicate class does not override equals() (hence you get a simple reference comparison). Here's a test that reproduces the issue:
class RouteEqualityTest {
@Test
void testTwoIdenticalRouteAreEqual() {
assertThat(getRouteBuilderStub().build()).isEqualTo(getRouteBuilderStub().build());
}
private Route.AsyncBuilder getRouteBuilderStub() {
return Route.async()
.id("123")
.uri("https://example.com")
.predicate(exchange -> exchange.getRequest()
.getPath()
.value()
.equals("/test-path"));
}
}