sourmash-bio/sourmash

write more tests for sourmash signature module

Open

#610 opened on Jan 8, 2019

View on GitHubContributor guide
 (1 comment) (0 reactions) (0 assignees)Python (94 forks)github user discovery
good second issuehelp wantedrepeatable quest

Repository metrics

Stars
 (555 stars)
PR merge metrics
 (Avg merge 4h 7m) (8 merged PRs in 30d)

Description

There are a variety of things that aren't well tested in the sourmash signature module - e.g. the --ksize and --dna/--protein flags aren't explicitly tested for most of the functions, and the tests of the --track-abundance signatures are not thorough. We should have more!

This is a great entry level task for people interested in contributing!

Contributor guide

Research direction
Write additional tests for the sourmash signature module, focusing on the ksize and dna/ protein flags, and improve coverage for track abundance signatures.
Tech stack
python
Domain
testingdata
Issue type
Test
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
PythonGit
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
85