sourcegraph/sourcegraph-public-snapshot

insights: dashboards PageInfo incorrectly reports there are additional pages

Open

#34,992 opened on May 5, 2022

View on GitHubContributor guide
 (1 comment) (0 reactions) (0 assignees)Go (1,374 forks)auto 404
backendbugcode-insightsgood first issuereliability

Repository metrics

Stars
 (10,290 stars)
PR merge metrics
 (PR metrics pending)

Description

When any of the arguments first, after or ID are passed to InsightsDashboardConnection the pageInfo returned will always indicate that there is an additional page. This is not always correct.

see InsightViewQueryConnectionResolver for working approach

Contributor guide

Research direction
Inspect the working approach in InsightViewQueryConnectionResolver (link in issue) and apply similar pagination logic to InsightsDashboardConnection to fix the PageInfo bug.
Tech stack
go
Domain
backendapi
Issue type
Bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Mostly clear
Prerequisites
GoGraphQL
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
75