sourcegraph/sourcegraph-public-snapshot

URL inserted into repositoriesMatchingQuery entry in batch spec returns 0 match

Open

#28,321 opened on Nov 29, 2021

View on GitHubContributor guide
 (3 comments) (0 reactions) (0 assignees)Go (1,374 forks)auto 404
batch-changesgood first issue

Repository metrics

Stars
 (10,290 stars)
PR merge metrics
 (PR metrics pending)

Description

Steps to reproduce:

  1. Create a batch spec
  2. Run a search query on the UI, and then copy the URL of that search, instead of the query itself, into the repositoriesMatchingQuery entry of the batch spec
  3. Run src batch preview -f quicktest.batch.yaml

Expected behavior:

An error message like Unexpected query passed

Actual behavior:

Returns 0 matches. Check image below image (4)

Contributor guide

Research direction
Examine the batch spec validation code to detect and reject URLs in the repositoriesMatchingQuery field, returning a clear error message instead of silently returning 0 matches.
Tech stack
go
Domain
backendapi
Issue type
Bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
GitGo
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
70