sourcegraph/sourcegraph-public-snapshot

Fix selection after running a settings quick action

Open

#2,756 opened on Mar 15, 2019

View on GitHubContributor guide
 (8 comments) (0 reactions) (2 assignees)Go (1,374 forks)auto 404
bugfrontend-platformgood first issuewebapp

Repository metrics

Stars
 (10,290 stars)
PR merge metrics
 (PR metrics pending)

Description

The settings quick actions (the buttons on the global/org/user settings JSON editor pages) yield the wrong selection after clicking them in some cases. The selection should be the newly added line, but it instead is the line above.

This only occurs for actions (such as setSearchContextLines) that DO NOT specify a selection text.

This is because the selection is computed as:

                    selection = monaco.Selection.fromPositions(
                        monacoEdits[0].range.getStartPosition(),
                        monacoEdits[monacoEdits.length - 1].range.getEndPosition()
                    )

and this breaks when the edit needs to add a trailing comma to the preceding line.

Contributor guide

Research direction
Investigate the selection calculation in the settings quick actions. The issue is that when an edit adds a trailing comma to the preceding line, the selection range is miscalculated. Fix the selection logic to correctly select the newly added line.
Tech stack
typescript
Domain
frontend
Issue type
Bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
TypeScriptGit
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
70