sourcegraph/sourcegraph-public-snapshot

Batch Change preview loses all changesets after a few days

Open

#20,146 opened on Apr 19, 2021

View on GitHubContributor guide
 (3 comments) (0 reactions) (0 assignees)Go (1,374 forks)auto 404
batch-changesgood first issue

Repository metrics

Stars
 (10,290 stars)
PR merge metrics
 (PR metrics pending)

Description

  • Sourcegraph version: 3.26.3
  • Platform information: Chrome 89 on Mac OS

Steps to reproduce:

  1. Create a Batch Change preview from a batch spec
  2. Verify that the preview link shows the Batch Change with all of the expected changesets
  3. Come back after a few days

Expected behavior:

I'm not sure if this is a bug or just an aggressive expiry of changesets created during a preview since previews are more ephemeral. If it is just an aggressive expiry, I would expect preview changesets to persist for much longer than just a few days. And I would also expect a message explaining that the changesets were discarded because the preview was created "N" days ago or something similar, rather than just an empty preview.

Actual behavior

The same preview link now shows a Batch Change with no changesets, like so:

image

I verified that this was not a mistake with the batch change spec by re-running the exact same preview command via our CI workflow, which created a new preview with all of the expected changesets that I had seen originally.

Contributor guide

Research direction
Investigate the expiration logic for batch change preview changesets and consider implementing a persistent message or increasing the expiry duration.
Tech stack
go
Domain
backend
Issue type
Bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
Half day
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
Go
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
60