sourcegraph/sourcegraph-public-snapshot

Add support for new GitHub check suite states

Open

#16,078 opened on Nov 23, 2020

View on GitHubContributor guide
 (5 comments) (0 reactions) (0 assignees)Go (1,374 forks)auto 404
batch-changesdebtgetting-changesets-mergedgood first issue

Repository metrics

Stars
 (10,290 stars)
PR merge metrics
 (PR metrics pending)

Description

GitHub added new states, so we should add them to the parsing function here: https://github.com/sourcegraph/sourcegraph/blob/main/enterprise/internal/batches/state/state.go#L335

// Schema Changes for 2020-02-05
// Enum value STALE was added to enum CheckConclusionState
// Enum value SKIPPED was added to enum CheckConclusionState

Contributor guide

Research direction
Locate the state parsing function at enterprise/internal/batches/state/state.go line 335. Add the new enum values 'STALE' and 'SKIPPED' to the switch case or mapping for CheckConclusionState.
Tech stack
go
Domain
backend
Issue type
Feature
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
Go
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
75