soundasleep/html2text

Abusive removal of br nodes leads to incorrect output

Open

#54 opened on Oct 17, 2017

View on GitHub
 (4 comments) (0 reactions) (0 assignees)HTML (138 forks)github user discovery
hacktoberfest

Repository metrics

Stars
 (485 stars)
PR merge metrics
 (No merged PRs in 30d)

Description

Hello !

There is some code doing intentional removal of nodes when they are the last child of a node that also contained text. Here's a very simple example about how this can lead to incorrect results (this is stuff I'm receiving from bad html emails) :

<font size="+1">Vikings: Wolves of Midgard<br></font><font size="+1">Valkyria Chronicles<br>
<br>
World Of Warcraft Battlechest</font>

The expected output would be

Vikings: Wolves of Midgard
Valkyria Chronicles

World Of Warcraft Battlechest

The actual output is:

Vikings: Wolves of MidgardValkyria Chronicles

World Of Warcraft Battlechest

Contributor guide

Research direction
Find the code section that intentionally removes <br> nodes when they are the last child of a node containing text. Debug the logic to ensure line breaks are preserved correctly.
Tech stack
php
Domain
backend
Issue type
Bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
php
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
70