sindresorhus/recycle-bin

By default, don't permanently delete when recycle bin doesn't exist

Open

#8 opened on Dec 18, 2020

View on GitHubContributor guide
 (1 comment) (0 reactions) (0 assignees)C (9 forks)user submission
enhancementhelp wanted

Repository metrics

Stars
 (71 stars)
PR merge metrics
 (No merged PRs in 30d)

Description

I think that's a better default. We can add a flag to get back the old behavior.

It seems like we can use the FOF_WANTNUKEWARNING flag for this:

Send a warning if a file or folder is being destroyed during a delete operation rather than recycled. This flag partially overrides FOF_NOCONFIRMATION. - https://docs.microsoft.com/en-us/windows/win32/api/shobjidl_core/nf-shobjidl_core-ifileoperation-setoperationflags

It's not immediately clear what they mean by warning and how we could check for that though.

Contributor guide

Research direction
Investigate the FOF WANTNUKEWARNING flag for IFileOperation to prevent permanent deletion when the recycle bin is missing. Implement a check and add a flag for the old behavior.
Tech stack
c
Domain
desktop
Issue type
Feature
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
Half day
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Mostly clear
Prerequisites
Windows API
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
50