sindresorhus/eslint-plugin-unicorn

Rule proposal: `prefer-regexp-dot-all`

Closed

#982 opened on Jan 1, 2021

View on GitHubContributor guide
 (2 comments) (2 reactions) (0 assignees)JavaScript (468 forks)user submission
help wantednew rule

Repository metrics

Stars
 (5,022 stars)
PR merge metrics
 (Avg merge 1d 16h) (399 merged PRs in 30d)

Description

https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/RegExp/dotAll

https://github.com/tc39/proposal-regexp-dotall-flag

This could be auto-fixed as long as the regex doesn't contain a . pattern. If it does, we can do a suggestion instead.

Fail

/foo[^]bar/.test('foo\nbar');
/foo[\s\S]bar/.test('foo\nbar');
/foo[\S\s]bar/.test('foo\nbar');
/foo[\w\W]bar/.test('foo\nbar');
/foo[\W\w]bar/.test('foo\nbar');
/foo[\d\D]bar/.test('foo\nbar');
/foo[\D\d]bar/.test('foo\nbar');

Pass

/foo.bar/s.test('foo\nbar');

Contributor guide

Research direction
Study existing rules in the eslint plugin unicorn repo (e.g., rules/) to understand the pattern for creating a new rule. Implement the `prefer regexp dot all` rule with an auto fix for regexes without a dot, and a suggestion for those containing a dot. Use test driven development and refer to the ESLint documentation for custom rules.
Tech stack
javascriptnodejs
Domain
toolingdeveloper experience
Issue type
Feature
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Fresh
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
ESLint rule developmentregex knowledge
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
70