sindresorhus/eslint-plugin-unicorn

Feature Request: expose `ignoredCallee` to `no-array-callback-reference` rule

Closed

#972 opened on Dec 30, 2020

View on GitHubContributor guide
 (10 comments) (1 reaction) (0 assignees)JavaScript (468 forks)user submission
enhancementhelp wanted

Repository metrics

Stars
 (5,022 stars)
PR merge metrics
 (Avg merge 1d 16h) (399 merged PRs in 30d)

Description

This rule is awesome, but with some older code in AngularJS, we find ourselves having to inline disable unicorn/no-array-callback-reference regularly where our code uses things like Angular.forEach. There are of course much more modern alternatives to this nowadays, but configuration is always helpful.

Rather than maintain this list privately, I think it would make sense to expose in the rule configuration so users can configure it for their own needs. Something like:

"unicorn/no-array-callback-reference": ["error", {
	"ignoredCallee": [
		"Promise",
		"React.children",
		"Children",
		"lodash",
		"underscore",
		"_",
		"Async",
		"async",
		"Angular"
	]
}]

Contributor guide

Research direction
Examine the file `rules/no array callback reference.js` to understand current hardcoded `ignoredCallee` list and rule structure. Review existing rule options in other unicorn rules for pattern. The issue requests adding a new option `ignoredCallee` to the schema. There are 10 comments, but no linked PRs or assignment, so the feature is still open for implementation. The maintainer may have guidelines on configuration option naming.
Tech stack
javascript
Domain
tooling
Issue type
Feature
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Mostly clear
Prerequisites
ESLint plugin basicsJavaScriptconfiguration options
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
45