sindresorhus/eslint-plugin-unicorn

Warn about misuse of `import-style` rule

Closed

#924 opened on Dec 7, 2020

View on GitHubContributor guide
 (1 comment) (2 reactions) (0 assignees)JavaScript (468 forks)user submission
help wanted

Repository metrics

Stars
 (5,022 stars)
PR merge metrics
 (Avg merge 1d 16h) (399 merged PRs in 30d)

Description

Follow-up to #899 and #910:

[…] Configurations like below in my opinion present a misuse of this rule.

      fs: {
        unassigned: false,
        default: false,
        namespace: false,
        named: false,
      },

I think it should be simply disallowed and no-restricted-imports or no-restricted-modules rules should be recommended to the user when such configuration is detected.

Originally posted by @futpib in https://github.com/sindresorhus/eslint-plugin-unicorn/issues/899#issuecomment-735985491

Contributor guide

Research direction
Implement a warning in the import style rule when all options (unassigned, default, namespace, named) are set to false, recommending the use of no restricted imports or no restricted modules instead. The main file to modify is likely rules/import style.js. Reference issues #899 and #910 for context, and the comment by @futpib for details.
Tech stack
javascriptnodejs
Domain
tooling
Issue type
Feature
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Mostly clear
Prerequisites
ESLint plugin developmentUnderstanding of import style rule
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
50