prevent-abbreviations renames parameter, but not reference to parameter in type guard signature

Repository metrics

Stars

5,022 stars (5,022 stars)

PR merge metrics

Avg merge 1d 16h (Avg merge 1d 16h)399 merged PRs in 30d (399 merged PRs in 30d)

Description

const isString = (val: unknown): val is string => typeof val === 'string'

const isString = (value: unknown): val is string => typeof value === 'string'

Contributor guide

Research direction

The issue reports that the `prevent abbreviations` rule incorrectly renames the parameter `val` to `value` in the function body but leaves the type guard signature parameter unchanged, causing a compilation error. To fix this, locate the rule's source file (likely in `rules/prevent abbreviations.js` or `.ts`). The fix should ensure that when renaming a parameter, all references in the function signature, including type predicates, are updated. Review the rule's implementation of parameter renaming and consider using AST traversal to replace all identifiers in the type guard signature. Check existing tests for similar cases and add a test case for type guard parameters.

Tech stack

javascripttypescriptnodejs

Domain

tooling

Issue type

Bug

DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.

3

Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.

1-3 hours

Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.

Stale

ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.

Mostly clear

Prerequisites

Basic understanding of ESLintFamiliarity with TypeScript type guards

Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.

55