sindresorhus/eslint-plugin-unicorn
Rule proposal: Forbid `.splice(index, 1, element)` and `.splice(-1, 0, element)`
Closed
#2,765 opened on Sep 25, 2025
help wantednew rule
Repository metrics
- Stars
- (5,022 stars)
- PR merge metrics
- (Avg merge 1d 16h) (399 merged PRs in 30d)
Description
Description
They are hard to read and confusing.
Examples
// ❌
array.splice(-1, 1, element);
array.splice(array.length - 1, 1, element); // This can be ignored since `unicorn/prefer-negative-index` already fix it to the previous one.
// ✅
array[array.length - 1] = element;
// ❌
array.splice(10, 1, element);
// ✅
array[10] = element;
// ❌
array.splice(-1, 0, element);
// ✅
array.push(element);
Proposed rule name
no-confusing-array-splice
Additional Info
I'm not sure about the rule name.
Note: the replacements in examples are not safe to fix, since they behavior differently when the index is out of boundary, even the -1 case, since the array can be empty.