Rule proposal: No multiple array check in logical expression

Repository metrics

Stars

5,022 stars (5,022 stars)

PR merge metrics

Avg merge 1d 16h (Avg merge 1d 16h)399 merged PRs in 30d (399 merged PRs in 30d)

Description

if (
	array.some(element => element.foo === 1)
	|| array.some(element => element.bar === 2)
) {}

if (
	array.every(element => element.foo === 1)
	&& array.every(element => element.bar === 2)
) {}

if (
	array.some(element => element.foo === 1 || element.bar === 2)
) {}

if (
	array.every(element => element.foo === 1 && element.bar === 2)
) {}

Contributor guide

Research direction

Examine existing rules in eslint plugin unicorn (e.g., rules/no array callback reference.js) for structure and patterns. Look at test files in test/snapshots/ and test/rules/ to understand test format. Create a new rule file in rules/ with the name 'no multiple array check' or similar, implement logic to detect repeated .some()/.every() calls on the same array in logical expressions, and write tests in test/rules/. Update the plugin's index.js to export the new rule and add documentation in docs/rules/. The issue provides clear fail and pass examples to guide implementation.

Tech stack

javascript

Domain

tooling

Issue type

Feature

DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.

3

Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.

1-2 days

Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.

Fresh

ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.

Clear

Prerequisites

ESLint plugin developmentJavaScriptAST

Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.

75