sindresorhus/eslint-plugin-unicorn

False positive `array-from-async` in `unicorn/no-unnecessary-polyfills`

Closed

#2,270 opened on Feb 6, 2024

View on GitHubContributor guide
 (0 comments) (0 reactions) (0 assignees)JavaScript (468 forks)user submission
bughelp wanted

Repository metrics

Stars
 (5,022 stars)
PR merge metrics
 (Avg merge 1d 16h) (399 merged PRs in 30d)

Description

Code:

import arrayFromAsync from "array-from-async"; // Error: Use built-in instead

package.json:

{
  "engines": {
    "node": ">=18"
  }
}

Array.fromAsync is not present in any Node.js version, not even v21, so it should not trigger no-unnecessary-polyfills.

Contributor guide

Research direction
Locate the rule definition for no unnecessary polyfills and add Array.fromAsync to the exclusion list.
Tech stack
javascript
Domain
tooling
Issue type
Bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Fresh
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
ESLint
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
75