sindresorhus/eslint-plugin-unicorn

Rule proposal: `prefer-unshift`

Closed

#2,165 opened on Jul 6, 2023

View on GitHubContributor guide
 (2 comments) (2 reactions) (0 assignees)JavaScript (468 forks)user submission
help wantednew rule

Repository metrics

Stars
 (5,022 stars)
PR merge metrics
 (Avg merge 1d 16h) (399 merged PRs in 30d)

Description

Description

I see my newbine team member write following code when I code review:

 sItems.splice(0, 0, { itemType: 'Ungroup' });

Fail

arr.splice(0, 0, {})

Pass

arr.unshift({})

Additional Info

maybe another proposal to suggest:

arr.splice(0, 1)

to:

arr.shift()

Contributor guide

Research direction
Implement a new ESLint rule named `prefer unshift` that detects `Array.prototype.splice(0, 0, ...)` and suggests `unshift`, and `splice(0, 1)` suggests `shift`. Study existing rules in this plugin for patterns.
Tech stack
javascript
Domain
tooling
Issue type
Feature
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
ESLint plugin development
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
75