sindresorhus/eslint-plugin-unicorn

[unicorn/prefer-at] should avoid auto fix " parent?.childNodes[parent.childNodes.length - 1];"

Closed

#2,098 opened on May 15, 2023

View on GitHubContributor guide
 (8 comments) (1 reaction) (0 assignees)JavaScript (468 forks)user submission
bughelp wantedtypes

Repository metrics

Stars
 (5,022 stars)
PR merge metrics
 (Avg merge 1d 16h) (399 merged PRs in 30d)

Description

origin:

parent?.childNodes[parent.childNodes.length - 1];

after auto fix:

parent?.childNodes.at(-1);

unicorn/prefer-at

not safe

Contributor guide

Research direction
Examine the rule implementation in the source file (likely rules/prefer at.js). Understand how the auto fix currently handles optional chaining. Look at existing tests to see if there is a test case for optional chaining with computed length. Consider adding a case to avoid the fix when the member expression uses optional chaining and the index is based on the parent's length property. Collaborate with maintainers for desired behavior.
Tech stack
javascriptnodejs
Domain
developer experiencetooling
Issue type
Bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
ESLint plugin developmentAST manipulation
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
40