sindresorhus/eslint-plugin-unicorn

Improve `prefer-dom-node-remove`

Closed

#2,085 opened on May 9, 2023

View on GitHubContributor guide
 (0 comments) (0 reactions) (0 assignees)JavaScript (468 forks)user submission
enhancementhelp wanted

Repository metrics

Stars
 (5,022 stars)
PR merge metrics
 (Avg merge 1d 16h) (399 merged PRs in 30d)

Description

  • Use snapshot test https://github.com/sindresorhus/eslint-plugin-unicorn/pull/2333
  • Improve fix, not use the original text but manipulate tokens
  • Improve fix for node?.parentNode.removeChild(node) (node can be anything, the object and the argument should be same reference, but can be different AST, eg: a?.b?.parentNode.remove(a.b))

Contributor guide

Research direction
Examine the existing fixer in `rules/prefer dom node remove.js` (likely in the repository). Review the merged PR #2333 for snapshot test style. For the second task, replace the use of original text with token manipulation by accessing AST tokens via `sourceCode.getTokens()` or similar. For the third task, handle optional chaining (e.g., `node?.parentNode.removeChild(node)`) ensuring the same reference is used in both the object and argument; consider using `sourceCode.getText()` or comparing AST nodes. Look at existing tests in `test/snapshots/prefer dom node remove.md` for guidance.
Tech stack
javascriptnodejs
Domain
developer experiencetooling
Issue type
Refactor
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Fresh
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Mostly clear
Prerequisites
Experience with ESLint rulesUnderstanding of ASTFamiliarity with fixer API
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
50