sindresorhus/eslint-plugin-unicorn

`prefer-regexp-test` catch more cases

Closed

#2,071 opened on Apr 18, 2023

View on GitHubContributor guide
 (1 comment) (1 reaction) (0 assignees)JavaScript (468 forks)user submission
enhancementhelp wanted

Repository metrics

Stars
 (5,022 stars)
PR merge metrics
 (Avg merge 1d 16h) (399 merged PRs in 30d)

Description

the below cases currently not reported

      if (
        uri.match(/unicorn/).length ||
        uri.match(/unicorn/).length > 0 ||
        uri.match(/unicorn/)?.length ||
        uri.match(/unicorn/)?.length > 0
      ) {

      }

Contributor guide

Research direction
Examine the rule implementation in `rules/prefer regexp test.js` to understand the current detection logic. The issue provides examples of `.match()` calls used in conditionals that are not being reported. Add detection for patterns like `expression.match(/pattern/).length` or `expression.match(/pattern/)?.length` in boolean contexts. Also update the corresponding test file to include these cases as expected violations.
Tech stack
javascript
Domain
toolingdeveloper experience
Issue type
Feature
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Fresh
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Mostly clear
Prerequisites
ESLint rule developmentunderstanding of regex patterns
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
45